Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Toggle color picker popover clicking preview button #589

Merged
merged 5 commits into from
Oct 16, 2023

Conversation

bjarnef
Copy link
Contributor

@bjarnef bjarnef commented Sep 29, 2023

Description

This move the preview button (when not inline color picker) inside <uui-popover> as the example here: https://uui.umbraco.com/?path=/docs/uui-popover--docs

This change also make it toggle the color picker when clicking the preview button, where it currently only opens.
I think the <uui-popover> need some changes, so it close when clicking the container as well, but not when clicking inside <div slot="popover"> (the actual popover).

In the example and this with color picker, there's an area next to the button, where clicking this doesn't close - it looks like outside the popover click, but is actually inside <uui-popover>.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Chore (minor updates related to the tooling or maintenance of the repository, does not impact compiled assets)

Motivation and context

How to test?

Screenshots (if appropriate)

chrome_4OTuce8FF5.mp4

Checklist

  • If my change requires a change to the documentation, I have updated the documentation in this pull request.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.

@github-actions
Copy link

Hi there @bjarnef, thank you for this contribution! 👍

While we wait for the team to have a look at your work, we wanted to let you know about that we have a checklist for some of the things we will consider during review:

  • It's clear what problem this is solving, there's a connected issue or a description of what the changes do and how to test them
  • The automated tests all pass (see "Checks" tab on this PR)
  • The level of security for this contribution is the same or improved
  • The level of performance for this contribution is the same or improved
  • Avoids creating breaking changes; note that behavioral changes might also be perceived as breaking
  • If this is a new feature, Umbraco HQ provided guidance on the implementation beforehand
  • 💡 The contribution looks original and the contributor is presumably allowed to share it

Don't worry if you got something wrong. We like to think of a pull request as the start of a conversation, we're happy to provide guidance on improving your contribution.

If you realize that you might want to make some changes then you can do that by adding new commits to the branch you created for this work and pushing new commits. They should then automatically show up as updates to this pull request.

Thanks, from your friendly Umbraco GitHub bot 🤖 🙂

@bjarnef
Copy link
Contributor Author

bjarnef commented Oct 5, 2023

@iOvergaard @loivsen I think this is better, but should the "outside-click" also work on popover container, e.g. when click the area next to the button (see also example here https://uui.umbraco.com/?path=/story/uui-popover--aaa-overview and while popover is open click a few pixel to the right of the button, where the popover isn't closed, because it's the container that is clicked, but not the actually visually part of the popover.

Co-authored-by: Lone Iversen <108085781+loivsen@users.noreply.github.com>
@bjarnef bjarnef requested a review from loivsen October 12, 2023 11:01
@loivsen loivsen merged commit bb839af into umbraco:v1/contrib Oct 16, 2023
@bjarnef bjarnef deleted the feature/color-picker-toggle branch October 16, 2023 08:11
# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants