-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Toggle color picker popover clicking preview button #589
Toggle color picker popover clicking preview button #589
Conversation
Hi there @bjarnef, thank you for this contribution! 👍 While we wait for the team to have a look at your work, we wanted to let you know about that we have a checklist for some of the things we will consider during review:
Don't worry if you got something wrong. We like to think of a pull request as the start of a conversation, we're happy to provide guidance on improving your contribution. If you realize that you might want to make some changes then you can do that by adding new commits to the branch you created for this work and pushing new commits. They should then automatically show up as updates to this pull request. Thanks, from your friendly Umbraco GitHub bot 🤖 🙂 |
@iOvergaard @loivsen I think this is better, but should the "outside-click" also work on popover container, e.g. when click the area next to the button (see also example here https://uui.umbraco.com/?path=/story/uui-popover--aaa-overview and while popover is open click a few pixel to the right of the button, where the popover isn't closed, because it's the container that is clicked, but not the actually visually part of the popover. |
Co-authored-by: Lone Iversen <108085781+loivsen@users.noreply.github.com>
Description
This move the preview button (when not inline color picker) inside
<uui-popover>
as the example here: https://uui.umbraco.com/?path=/docs/uui-popover--docsThis change also make it toggle the color picker when clicking the preview button, where it currently only opens.
I think the
<uui-popover>
need some changes, so it close when clicking the container as well, but not when clicking inside<div slot="popover">
(the actual popover).In the example and this with color picker, there's an area next to the button, where clicking this doesn't close - it looks like outside the popover click, but is actually inside
<uui-popover>
.Types of changes
Motivation and context
How to test?
Screenshots (if appropriate)
chrome_4OTuce8FF5.mp4
Checklist