-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Umccrise tidy #127
Merged
Merged
Umccrise tidy #127
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Sep 11, 2024
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Quite a few enhancements/changes.
Wf
super class which is the base forWf_*
subclasses.Wf_umccrise
subclass{paws}
/{paws.storage}
for everything.umccrise
summary reporterWf
This class has:
fields:
path
: a directory with raw workflow results (can be GDS, S3 or local filesystem)wname
: workflow name (e.g. umccrise, sash)filesystem
: gds, s3, localregexes
: a tibble with fileregex
andfun
ction to parse itmethods:
list_files
: List all files under given path.list_files_filter_relevant
: List 'dracarys' files under given pathdownload_files
: Download files from GDS/S3 to local filesystem (for debugging/exploration)tidy_files
: Tidy/process fileswrite
: Write tidy tables to database/parquet/tsv/rds etc.A neat trick it utilises under the hood is
eval(parse(text = f), envir = self)
, whereself
allows it to use parsers from each individual subclass, which is pretty tricky to get working properly.Wf_umccrise
cancer_report_tables/
(signatures for SNV/DBS/Indel, HRD from CHORD/HRDetect, QC summary),conpair/
, and the PCGR JSON (for MSI).list_files_filter_relevant
).Wf_umccrise_download_tidy_write
is a neat wrapper that does what it saysS3
s3_file_presignedurl
: usesgenerate_presigned_url
frompaws.storage
. The client needs to have a v4 signature version (paws.storage::s3(paws.storage::config(signature_version = "s3v4"))
).umccrise summary