Skip to content

Commit

Permalink
chore: price-feeder ctx cleanup (#1098)
Browse files Browse the repository at this point in the history
Removes an unnecessary additional context from the price-feeder height subscription logic as mentioned [here](#1084 (comment))

---

### Author Checklist

_All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues._

I have...

- [ ] included the correct [type prefix](https://github.com/commitizen/conventional-commit-types/blob/v3.0.0/index.json) in the PR title
- [ ] added `!` to the type prefix if API or client breaking change
- [ ] added appropriate labels to the PR
- [ ] targeted the correct branch (see [PR Targeting](https://github.com/umee-network/umee/blob/main/CONTRIBUTING.md#pr-targeting))
- [ ] provided a link to the relevant issue or specification
- [ ] added a changelog entry to `CHANGELOG.md`
- [ ] included comments for [documenting Go code](https://blog.golang.org/godoc)
- [ ] updated the relevant documentation or specification
- [ ] reviewed "Files changed" and left comments if necessary
- [ ] confirmed all CI checks have passed

### Reviewers Checklist

_All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items._

I have...

- [ ] confirmed the correct [type prefix](https://github.com/commitizen/conventional-commit-types/blob/v3.0.0/index.json) in the PR title
- [ ] confirmed all author checklist items have been addressed
- [ ] reviewed state machine logic
- [ ] reviewed API design and naming
- [ ] reviewed documentation is accurate
- [ ] reviewed tests and test coverage
- [ ] manually tested (if applicable)
  • Loading branch information
adamewozniak authored Jul 5, 2022
1 parent 75476fa commit dc5a0c0
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 1 deletion.
1 change: 1 addition & 0 deletions price-feeder/cmd/price-feeder.go
Original file line number Diff line number Diff line change
Expand Up @@ -119,6 +119,7 @@ func priceFeederCmdHandler(cmd *cobra.Command, args []string) error {
}

oracleClient, err := client.NewOracleClient(
ctx,
logger,
cfg.Account.ChainID,
cfg.Keyring.Backend,
Expand Down
3 changes: 2 additions & 1 deletion price-feeder/oracle/client/client.go
Original file line number Diff line number Diff line change
Expand Up @@ -54,6 +54,7 @@ type (
)

func NewOracleClient(
ctx context.Context,
logger zerolog.Logger,
chainID string,
keyringBackend string,
Expand Down Expand Up @@ -99,7 +100,7 @@ func NewOracleClient(
}

chainHeight, err := NewChainHeight(
context.Background(),
ctx,
clientCtx.Client,
oracleClient.Logger,
blockHeight,
Expand Down

0 comments on commit dc5a0c0

Please # to comment.