Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

x/leverage: Increase testing of msg response return values #1242

Closed
toteki opened this issue Aug 15, 2022 · 0 comments · Fixed by #1300
Closed

x/leverage: Increase testing of msg response return values #1242

toteki opened this issue Aug 15, 2022 · 0 comments · Fixed by #1300

Comments

@toteki
Copy link
Member

toteki commented Aug 15, 2022

Currently MsgSupply, MsgWithdraw, MsgRepay, and MsgLiquidate have tests in keeper_test.go which check their return values against expected values.

These tests could be improved by making them case-based (and increasing the number of situations covered) as well as checking the consistency of the returned values (e.g. collateral received) against actual changes in balances, to catch any scenarios where the effects of a transaction do not match its reported returns.

# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant