-
Notifications
You must be signed in to change notification settings - Fork 161
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
feat!: Add informative response fields for leverage messages #1236
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
many good updates.
- let's don't store in response a copy of input - no need to pollute storage
- proto messages should follow the API language - we decided to use Assest rather than coin / token. If we want to change the language of API, then it's better to firstly discuss it on Slack, rather than in PR (unless something is small) to avoid going too much back and forth.
Co-authored-by: Robert Zaremba <robert@zaremba.ch>
Codecov Report
@@ Coverage Diff @@
## main #1236 +/- ##
==========================================
- Coverage 50.53% 50.46% -0.07%
==========================================
Files 67 67
Lines 6831 6838 +7
==========================================
- Hits 3452 3451 -1
- Misses 3135 3143 +8
Partials 244 244
|
Note: I intend to write some newly possible tests in |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pre-approving.
- please add at least one test with a new response
- create an issue to add more tests.
Initial tests added. Test improvement issue created at #1242 |
Main changes:
Message
types now return anysdk.Coins
representing effects achieved that are not equal to input fields. This includes uTokens received when supplying, and base tokens received when withdrawing.And some miscellaneous changes:
make proto-all
for ideal execution. (Format first, then lint, then generate, then swagger)Coin
->Asset
inMsgCollateralize
andMsgDecollateralize
repay_borrowed_asset
is now justrepay
supply
attributeamount
removed, now hassupplied
andreceived
withdraw
attributeamount
removed, now hasredeemed
andreceived
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!
to the type prefix if API or client breaking changeCHANGELOG.md
Reviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...