-
Notifications
You must be signed in to change notification settings - Fork 161
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
feat: token cache #1068
feat: token cache #1068
Conversation
Not super sure we need this imo, would cacheing the leverage token registry reduce load by that much? |
This is used in every tx method |
Also this is a safe cache. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
utACK - as long as unit tests pass I'm good
Unit tests right now are getting a lot of this
Is there something in |
Probably keeper is not initialized correctly. Checking it. BTW, |
Codecov Report
@@ Coverage Diff @@
## main #1068 +/- ##
==========================================
+ Coverage 43.30% 43.32% +0.02%
==========================================
Files 65 65
Lines 8371 8383 +12
==========================================
+ Hits 3625 3632 +7
- Misses 4498 4502 +4
- Partials 248 249 +1
|
Description
closes: #1064
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!
to the type prefix if API or client breaking changeCHANGELOG.md
Reviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...