Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

chore!: remove request suffix from leverage and oracle queries #1123

Merged
merged 3 commits into from
Jul 11, 2022

Conversation

toteki
Copy link
Member

@toteki toteki commented Jul 11, 2022

Description

Changes Query...Request to Query... for all queries in the leverage module.

Note @adamewozniak: Oracle proto has been modified as well.

closes: #1104


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • added appropriate labels to the PR
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

@toteki toteki changed the title remove request suffix from leverage queries chore!: remove request suffix from leverage queries Jul 11, 2022
@toteki toteki marked this pull request as ready for review July 11, 2022 16:34
@toteki toteki requested review from a team as code owners July 11, 2022 16:34
Copy link
Member Author

@toteki toteki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Diff is only renaming here

@codecov-commenter
Copy link

Codecov Report

Merging #1123 (6231862) into main (c04a703) will not change coverage.
The diff coverage is 0.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1123   +/-   ##
=======================================
  Coverage   43.82%   43.82%           
=======================================
  Files          65       65           
  Lines        8393     8393           
=======================================
  Hits         3678     3678           
  Misses       4472     4472           
  Partials      243      243           
Impacted Files Coverage Δ
x/leverage/client/cli/query.go 0.00% <0.00%> (ø)
x/leverage/keeper/grpc_query.go 5.67% <ø> (ø)
x/leverage/types/query.pb.gw.go 0.00% <0.00%> (ø)

@RafilxTenfen
Copy link
Contributor

should we do the same for oracle package in another PR?

@toteki
Copy link
Member Author

toteki commented Jul 11, 2022

should we do the same for oracle package in another PR?

If @WoZ is good with it, I can add oracle queries to this PR

@toteki toteki changed the title chore!: remove request suffix from leverage queries chore!: remove request suffix from leverage and oracle queries Jul 11, 2022
Copy link
Collaborator

@adamewozniak adamewozniak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm! Thanks for doing this in oracle

@toteki toteki merged commit c1a31c0 into main Jul 11, 2022
@toteki toteki deleted the adam/querysuffix branch July 11, 2022 17:47
# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

proto: remove unnecessary suffixes
4 participants