-
Notifications
You must be signed in to change notification settings - Fork 161
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
feat: setting protocol controlled min gas price #1326
Conversation
65706a8
to
d619786
Compare
Codecov Report
@@ Coverage Diff @@
## main #1326 +/- ##
==========================================
+ Coverage 52.22% 52.46% +0.24%
==========================================
Files 69 70 +1
Lines 6836 6877 +41
==========================================
+ Hits 3570 3608 +38
- Misses 2988 2990 +2
- Partials 278 279 +1
|
72d904d
to
7109f84
Compare
7109f84
to
3cede55
Compare
5893f6a
to
bed21c5
Compare
bed21c5
to
ddaf886
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm! @RafilxTenfen asked the questions I was going to lol
might be worth adding changelog here @robert-zaremba
@RafilxTenfen can you check on why the v1->v3 test is failing? https://github.com/umee-network/umee/runs/8257796548?check_suite_focus=true I think everything else is g2g |
Description
Closes: #1214
This is a "v1" solution for requiring min-gas price. More flexible mechanism (#1017) we will develop for v4 (or v5).
Notes:
fee-notes.md
files with stats for the fees.Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!
to the type prefix if API or client breaking changeCHANGELOG.md
Reviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...