Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

feat: implement MinCollateralLiquidity #1331

Merged
merged 28 commits into from
Sep 6, 2022
Merged

feat: implement MinCollateralLiquidity #1331

merged 28 commits into from
Sep 6, 2022

Conversation

toteki
Copy link
Member

@toteki toteki commented Sep 5, 2022

Description

closes: #1163


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • added appropriate labels to the PR
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@toteki toteki changed the base branch from main to adam/c2 September 5, 2022 04:40
@codecov-commenter
Copy link

codecov-commenter commented Sep 5, 2022

Codecov Report

Merging #1331 (5480254) into main (6e9fade) will increase coverage by 0.18%.
The diff coverage is 86.53%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1331      +/-   ##
==========================================
+ Coverage   51.91%   52.09%   +0.18%     
==========================================
  Files          69       69              
  Lines        6775     6816      +41     
==========================================
+ Hits         3517     3551      +34     
- Misses       2983     2988       +5     
- Partials      275      277       +2     
Impacted Files Coverage Δ
x/leverage/keeper/grpc_query.go 63.63% <80.95%> (+0.19%) ⬆️
x/leverage/keeper/collateral.go 69.17% <86.95%> (+3.71%) ⬆️
x/leverage/keeper/keeper.go 66.66% <100.00%> (+0.79%) ⬆️
x/leverage/keeper/limits.go 15.62% <100.00%> (ø)

@toteki
Copy link
Member Author

toteki commented Sep 5, 2022

Note: Merge #1329 then #1330 before this

@toteki toteki marked this pull request as ready for review September 5, 2022 05:17
@toteki toteki requested review from a team as code owners September 5, 2022 05:17
Copy link
Contributor

@khoerling khoerling left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks solid, haven't pulled this down to run locally yet...

Base automatically changed from adam/c2 to main September 6, 2022 19:35
@toteki toteki merged commit ca6338a into main Sep 6, 2022
@toteki toteki deleted the adam/c3 branch September 6, 2022 21:02
# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

leverage: implement MinCollateralLiquidity restriction
4 participants