Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

chore: bump GB #1474

Merged
merged 7 commits into from
Oct 7, 2022
Merged

chore: bump GB #1474

merged 7 commits into from
Oct 7, 2022

Conversation

robert-zaremba
Copy link
Member

@robert-zaremba robert-zaremba commented Oct 6, 2022

Description

Updates GB. All claims are enabled, but the slashing is still off.
Partially closes: #1403
Depends on: #1478


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • added appropriate labels to the PR
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@robert-zaremba robert-zaremba requested a review from a team as a code owner October 6, 2022 03:36
@RafilxTenfen
Copy link
Contributor

why not release umee GB v1.5.3-umee-3 ?

@toteki
Copy link
Member

toteki commented Oct 6, 2022

"Update SDK" commit has introduced compile time errors @robert-zaremba

@robert-zaremba
Copy link
Member Author

why not release umee GB v1.5.3-umee-3 ?

Because this is not a proper release: slashing is off and messages are on, which should not be marked as a version that anyone should use (except us)

@robert-zaremba
Copy link
Member Author

"Update SDK" commit has introduced compile time errors @robert-zaremba

This PR depends on #1478 . Once it will be merge, we need to update this one.

@robert-zaremba
Copy link
Member Author

Ping. Kindly requesting review

@mergify mergify bot merged commit 206c309 into main Oct 7, 2022
@mergify mergify bot deleted the robert/gb-update branch October 7, 2022 01:23
@RafilxTenfen
Copy link
Contributor

why not release umee GB v1.5.3-umee-3 ?

Because this is not a proper release: slashing is off and messages are on, which should not be marked as a version that anyone should use (except us)

Okay, agree with that

One thing to keep in mind for the next not even a PR was made on https://github.com/umee-network/Gravity-Bridge, only a commit and we referenced that on this go.mod makes it harder to see the changes...
@robert-zaremba

# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

re-enable full functionality of GB
3 participants