Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

chore!: refactore store key constructors #1578

Merged
merged 14 commits into from
Nov 12, 2022
Merged

chore!: refactore store key constructors #1578

merged 14 commits into from
Nov 12, 2022

Conversation

robert-zaremba
Copy link
Member

Description

Follow up on #1573
Cleanup store key prefix functions.


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • added appropriate labels to the PR
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@robert-zaremba robert-zaremba requested review from a team as code owners November 11, 2022 14:51
@robert-zaremba robert-zaremba changed the title Robert/oracle getters chore: refactore store key constructors Nov 11, 2022
Copy link
Contributor

@rbajollari rbajollari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Copy link
Collaborator

@gsk967 gsk967 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@toteki
Copy link
Member

toteki commented Nov 11, 2022

Hold on before merging this - I want to test it against mainnet store

@codecov-commenter
Copy link

codecov-commenter commented Nov 11, 2022

Codecov Report

Merging #1578 (022b9e7) into main (56b89e0) will increase coverage by 0.38%.
The diff coverage is 94.64%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1578      +/-   ##
==========================================
+ Coverage   52.08%   52.47%   +0.38%     
==========================================
  Files          72       73       +1     
  Lines        7092     7040      -52     
==========================================
  Hits         3694     3694              
+ Misses       3125     3073      -52     
  Partials      273      273              
Impacted Files Coverage Δ
x/oracle/types/keys.go 60.00% <71.42%> (+17.89%) ⬆️
util/bytes.go 100.00% <100.00%> (ø)
x/leverage/keeper/invariants.go 72.64% <100.00%> (-0.46%) ⬇️
x/leverage/keeper/iter.go 54.08% <100.00%> (ø)
x/leverage/keeper/store.go 65.58% <100.00%> (-0.66%) ⬇️
x/leverage/keeper/token.go 76.00% <100.00%> (ø)
x/leverage/types/keys.go 100.00% <100.00%> (+47.61%) ⬆️
x/oracle/keeper/historic_price.go 93.93% <100.00%> (+0.12%) ⬆️
x/oracle/keeper/keeper.go 84.79% <100.00%> (ø)

Copy link
Member

@toteki toteki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good - also I added some leverage key_test.go cases.

@robert-zaremba
Copy link
Member Author

Looks good - also I added some leverage key_test.go cases.

Thank you.

Co-authored-by: Adam Moser <63419657+toteki@users.noreply.github.com>
@robert-zaremba robert-zaremba requested a review from a team as a code owner November 12, 2022 09:09
@robert-zaremba robert-zaremba changed the title chore: refactore store key constructors chore!: refactore store key constructors Nov 12, 2022
@mergify mergify bot merged commit b40ed0d into main Nov 12, 2022
@mergify mergify bot deleted the robert/oracle-getters branch November 12, 2022 09:51
# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants