-
Notifications
You must be signed in to change notification settings - Fork 161
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
chore!: refactore store key constructors #1578
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Hold on before merging this - I want to test it against mainnet store |
Codecov Report
@@ Coverage Diff @@
## main #1578 +/- ##
==========================================
+ Coverage 52.08% 52.47% +0.38%
==========================================
Files 72 73 +1
Lines 7092 7040 -52
==========================================
Hits 3694 3694
+ Misses 3125 3073 -52
Partials 273 273
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good - also I added some leverage key_test.go
cases.
Thank you. |
Co-authored-by: Adam Moser <63419657+toteki@users.noreply.github.com>
Description
Follow up on #1573
Cleanup store key prefix functions.
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!
to the type prefix if API or client breaking changeCHANGELOG.md
Reviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...