Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

feat!: Add medians param to Token struct #1685

Merged
merged 7 commits into from
Jan 6, 2023
Merged

feat!: Add medians param to Token struct #1685

merged 7 commits into from
Jan 6, 2023

Conversation

toteki
Copy link
Member

@toteki toteki commented Jan 5, 2023

Additional testing is needed to make sure this doesn't break mainnet state, old governance (containing Token struct), etc.

See the PR #1689 liked for one optimistic test and some more notes.


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • added appropriate labels to the PR
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@codecov-commenter
Copy link

Codecov Report

Merging #1685 (401599c) into main (d76c155) will not change coverage.
The diff coverage is 50.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1685   +/-   ##
=======================================
  Coverage   57.97%   57.97%           
=======================================
  Files          73       73           
  Lines        7821     7821           
=======================================
  Hits         4534     4534           
  Misses       2934     2934           
  Partials      353      353           
Impacted Files Coverage Δ
x/leverage/keeper/oracle.go 62.93% <50.00%> (ø)

@toteki toteki mentioned this pull request Jan 5, 2023
@toteki toteki marked this pull request as ready for review January 5, 2023 21:22
@toteki toteki requested review from a team as code owners January 5, 2023 21:22
Copy link
Collaborator

@adamewozniak adamewozniak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this lgtm! this will change the leverage registry query response. let's get another review on here too
cc: @EbrahimUmee

Copy link
Collaborator

@adamewozniak adamewozniak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good!

@adamewozniak adamewozniak merged commit deb4dc4 into main Jan 6, 2023
@adamewozniak adamewozniak deleted the adam/param branch January 6, 2023 02:34
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants