-
Notifications
You must be signed in to change notification settings - Fork 161
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
feat!: Add medians param to Token struct #1685
Conversation
Codecov Report
@@ Coverage Diff @@
## main #1685 +/- ##
=======================================
Coverage 57.97% 57.97%
=======================================
Files 73 73
Lines 7821 7821
=======================================
Hits 4534 4534
Misses 2934 2934
Partials 353 353
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this lgtm! this will change the leverage registry query response. let's get another review on here too
cc: @EbrahimUmee
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good!
Additional testing is needed to make sure this doesn't break mainnet state, old governance (containing
Token
struct), etc.See the PR #1689 liked for one optimistic test and some more notes.
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!
to the type prefix if API or client breaking changeCHANGELOG.md
Reviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...