Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

fix: ballot sorting #1851

Merged
merged 3 commits into from
Feb 20, 2023
Merged

fix: ballot sorting #1851

merged 3 commits into from
Feb 20, 2023

Conversation

robert-zaremba
Copy link
Member

Description

@codecov-commenter
Copy link

Codecov Report

Merging #1851 (42a92ff) into main (95924b6) will decrease coverage by 0.01%.
The diff coverage is 57.14%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1851      +/-   ##
==========================================
- Coverage   56.92%   56.91%   -0.01%     
==========================================
  Files          93       93              
  Lines        8791     8797       +6     
==========================================
+ Hits         5004     5007       +3     
- Misses       3422     3424       +2     
- Partials      365      366       +1     
Impacted Files Coverage Δ
x/oracle/types/ballot.go 94.11% <57.14%> (-2.76%) ⬇️

@robert-zaremba robert-zaremba marked this pull request as ready for review February 20, 2023 18:55
@robert-zaremba robert-zaremba requested a review from a team as a code owner February 20, 2023 18:55
@robert-zaremba robert-zaremba added this pull request to the merge queue Feb 20, 2023
Merged via the queue into main with commit 9ba9310 Feb 20, 2023
@robert-zaremba robert-zaremba deleted the robert/sorting branch February 20, 2023 20:32
mergify bot pushed a commit that referenced this pull request Feb 20, 2023
* fix: ballot sorting

* test sorting

(cherry picked from commit 9ba9310)
robert-zaremba added a commit that referenced this pull request Feb 20, 2023
* fix: ballot sorting (#1851)

* fix: ballot sorting

* test sorting

(cherry picked from commit 9ba9310)

* make go-mod-tidy

---------

Co-authored-by: Robert Zaremba <robert@zaremba.ch>
Co-authored-by: toteki <63419657+toteki@users.noreply.github.com>
# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants