Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

feat: integrate ICA #1963

Merged
merged 4 commits into from
Mar 30, 2023
Merged

feat: integrate ICA #1963

merged 4 commits into from
Mar 30, 2023

Conversation

robert-zaremba
Copy link
Member

Description

  • Integrates IBC ICA Host stack.
  • also added few comments for IBC fee integration for the future.

@robert-zaremba robert-zaremba requested a review from a team as a code owner March 30, 2023 14:09
Base automatically changed from robert/bump-ibc to main March 30, 2023 14:19
@github-actions github-actions bot requested a review from a team as a code owner March 30, 2023 14:19
gsk967
gsk967 requested changes Mar 30, 2023
View reviewed changes
Copy link
Collaborator

@gsk967 gsk967 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When I try to build and run the binary in local it is not running,
We need to add icahosttypes.StoreKey in storeKeys

gsk967
gsk967 approved these changes Mar 30, 2023
View reviewed changes
Copy link
Collaborator

@gsk967 gsk967 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@robert-zaremba robert-zaremba added this pull request to the merge queue Mar 30, 2023
Merged via the queue into main with commit 89ee005 Mar 30, 2023
@robert-zaremba robert-zaremba deleted the robert/ica branch March 30, 2023 17:37
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@gsk967 gsk967 gsk967 approved these changes

Assignees
No one assigned
Labels
C:IBC
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@robert-zaremba @gsk967