chore: add checks for duplicate symbol denoms for adding new tokens on leverage #1989
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #1989 +/- ##
==========================================
+ Coverage 75.38% 75.40% +0.01%
==========================================
Files 100 100
Lines 8025 8029 +4
==========================================
+ Hits 6050 6054 +4
Misses 1589 1589
Partials 386 386
|
| @@ -76,6 +76,7 @@ Ref: https://keepachangelog.com/en/1.0.0/ | |||
| - [1954](https://github.com/umee-network/umee/pull/1954) Leverage: `MaxBorrow` now accounts for | |||
| `MinCollateralLiquidity` and `MaxSupplyUtilization` | |||
| - [1968](https://github.com/umee-network/umee/pull/1968) Leverage: fix type cast of AdjustedBorrow in ExportGenesis | |||
| - [1989](https://github.com/umee-network/umee/pull/1989) Leverage: fix the duplicate symbol denoms issue on adding new tokens to registry. | |||
There was a problem hiding this comment.
wrong line. It should be in "Improvements" under unreleased.
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
closes: #1883
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!to the type prefix if API or client breaking changeCHANGELOG.mdReviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...