Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

fix: int64 overflow in module liquidity #2072

Merged
merged 4 commits into from
May 30, 2023
Merged

fix: int64 overflow in module liquidity #2072

merged 4 commits into from
May 30, 2023

Conversation

toteki
Copy link
Member

@toteki toteki commented May 30, 2023

Description

closes: #XXXX


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • added appropriate labels to the PR
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@toteki toteki added the T:Bug A regression or bug in the Umee codebase. label May 30, 2023
@toteki toteki requested review from a team as code owners May 30, 2023 15:33
@codecov
Copy link

codecov bot commented May 30, 2023

Codecov Report

Merging #2072 (a77954e) into main (7f05ad4) will decrease coverage by 4.81%.
The diff coverage is 60.09%.

❗ Current head a77954e differs from pull request most recent head ada0a6a. Consider uploading reports for the commit ada0a6a to get more accurate results

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2072      +/-   ##
==========================================
- Coverage   75.38%   70.58%   -4.81%     
==========================================
  Files         100      126      +26     
  Lines        8025     9580    +1555     
==========================================
+ Hits         6050     6762     +712     
- Misses       1589     2352     +763     
- Partials      386      466      +80     
Impacted Files Coverage Δ
ante/spam_prevention.go 75.92% <ø> (ø)
util/store/unmarshal.go 0.00% <0.00%> (ø)
x/incentive/codec.go 47.82% <ø> (+9.89%) ⬆️
x/incentive/keeper/hooks.go 0.00% <0.00%> (ø)
x/incentive/keeper/invariants.go 0.00% <0.00%> (ø)
x/incentive/keeper/keeper.go 64.28% <ø> (ø)
x/leverage/keeper/errors.go 100.00% <ø> (ø)
x/leverage/keeper/exchange_rate.go 72.72% <ø> (ø)
x/leverage/keeper/genesis.go 87.23% <ø> (ø)
x/leverage/keeper/grpc_query.go 67.21% <ø> (ø)
... and 80 more

... and 13 files with indirect coverage changes

Copy link
Member

@robert-zaremba robert-zaremba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pre-approving, let's also include a test to prove the overflow.

@toteki toteki enabled auto-merge May 30, 2023 17:41
@toteki toteki added this pull request to the merge queue May 30, 2023
Merged via the queue into main with commit 7ebe89d May 30, 2023
@toteki toteki deleted the adam/int64 branch May 30, 2023 17:57
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
T:Bug A regression or bug in the Umee codebase.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants