Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

feat: autofill empty denoms in MsgLeveragedLiquidate #2121

Merged
merged 5 commits into from
Jun 30, 2023
Merged

Conversation

toteki
Copy link
Member

@toteki toteki commented Jun 29, 2023

No description provided.

@toteki toteki marked this pull request as ready for review June 29, 2023 15:29
@toteki toteki requested review from a team as code owners June 29, 2023 15:29
@codecov
Copy link

codecov bot commented Jun 29, 2023

Codecov Report

Merging #2121 (2c1880d) into main (7f05ad4) will decrease coverage by 0.75%.
The diff coverage is 77.39%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2121      +/-   ##
==========================================
- Coverage   75.38%   74.64%   -0.75%     
==========================================
  Files         100      127      +27     
  Lines        8025     9895    +1870     
==========================================
+ Hits         6050     7386    +1336     
- Misses       1589     2007     +418     
- Partials      386      502     +116     
Impacted Files Coverage Δ
ante/spam_prevention.go 75.92% <ø> (ø)
x/incentive/codec.go 47.82% <ø> (+9.89%) ⬆️
x/incentive/keeper/invariants.go 0.00% <0.00%> (ø)
x/leverage/client/tests/suite.go 100.00% <ø> (ø)
x/leverage/client/tests/tests.go 100.00% <ø> (ø)
x/leverage/keeper/borrows.go 75.93% <ø> (-2.64%) ⬇️
x/leverage/keeper/collateral.go 72.72% <ø> (-0.16%) ⬇️
x/leverage/keeper/errors.go 100.00% <ø> (ø)
x/leverage/keeper/exchange_rate.go 72.72% <ø> (ø)
x/leverage/keeper/genesis.go 87.23% <ø> (ø)
... and 62 more

... and 25 files with indirect coverage changes

Copy link
Member

@robert-zaremba robert-zaremba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if we merge this, we should also update comments in tx.proto -> rpc section.

Copy link
Contributor

@EbrahimElbagory EbrahimElbagory left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@toteki toteki enabled auto-merge June 30, 2023 00:55
@toteki toteki added this pull request to the merge queue Jun 30, 2023
Merged via the queue into main with commit c813da8 Jun 30, 2023
@toteki toteki deleted the adam/emptyliq branch June 30, 2023 01:11
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants