Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

refactore(leverage): rename ExchangeToken #2180

Merged
merged 12 commits into from
Aug 2, 2023

Conversation

robert-zaremba
Copy link
Member

@robert-zaremba robert-zaremba commented Aug 2, 2023

Description

ref: #2167 (comment)

  • fixed go mocks in metoken (they were outdated)
  • fixed intest in quota (it was using wrong constructor)

@robert-zaremba robert-zaremba requested a review from a team as a code owner August 2, 2023 16:57
@robert-zaremba robert-zaremba requested a review from a team as a code owner August 2, 2023 16:59
Copy link
Member

@toteki toteki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's think of a better name

@toteki
Copy link
Member

toteki commented Aug 2, 2023

Maybe ToToken() and ToUToken()?

@robert-zaremba
Copy link
Member Author

Maybe ToToken() and ToUToken()?

OK

@robert-zaremba robert-zaremba requested a review from toteki August 2, 2023 17:13
Copy link
Member

@toteki toteki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a little cleanup

robert-zaremba and others added 2 commits August 2, 2023 19:25
Co-authored-by: Adam Moser <63419657+toteki@users.noreply.github.com>
@robert-zaremba robert-zaremba requested a review from toteki August 2, 2023 17:54
robert-zaremba and others added 2 commits August 2, 2023 19:55
Co-authored-by: Adam Moser <63419657+toteki@users.noreply.github.com>
@codecov
Copy link

codecov bot commented Aug 2, 2023

Codecov Report

Merging #2180 (c50332b) into main (7f05ad4) will decrease coverage by 6.44%.
Report is 165 commits behind head on main.
The diff coverage is 82.35%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2180      +/-   ##
==========================================
- Coverage   75.38%   68.95%   -6.44%     
==========================================
  Files         100      152      +52     
  Lines        8025    11674    +3649     
==========================================
+ Hits         6050     8050    +2000     
- Misses       1589     3082    +1493     
- Partials      386      542     +156     
Files Changed Coverage Δ
ante/spam_prevention.go 75.92% <ø> (ø)
x/incentive/codec.go 47.82% <ø> (+9.89%) ⬆️
x/incentive/keeper/invariants.go 0.00% <0.00%> (ø)
x/incentive/keeper/store.go 70.67% <ø> (ø)
x/incentive/keeper/unbonding.go 80.45% <ø> (ø)
x/incentive/keeper/update.go 52.11% <ø> (ø)
x/incentive/keys.go 100.00% <ø> (ø)
x/incentive/msgs.go 77.41% <ø> (-0.81%) ⬇️
x/incentive/params.go 89.28% <ø> (-10.72%) ⬇️
x/leverage/client/tests/suite.go 100.00% <ø> (ø)
... and 54 more

... and 59 files with indirect coverage changes

Copy link
Contributor

@kosegor kosegor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approving x/metoken module part

@robert-zaremba robert-zaremba added this pull request to the merge queue Aug 2, 2023
Merged via the queue into main with commit 5ed92de Aug 2, 2023
@robert-zaremba robert-zaremba deleted the robert/rename-exchangetoken branch August 2, 2023 18:20
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants