Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

fix: fixing the amino-json sign on MsgLeveragedLiquidate #2196

Merged
merged 1 commit into from
Aug 14, 2023

Conversation

gsk967
Copy link
Collaborator

@gsk967 gsk967 commented Aug 14, 2023

Description

closes: #XXXX


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • added appropriate labels to the PR
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@gsk967 gsk967 requested a review from a team as a code owner August 14, 2023 12:55
0xhema

This comment was marked as spam.

@codecov
Copy link

codecov bot commented Aug 14, 2023

Codecov Report

Merging #2196 (9406832) into main (7f05ad4) will decrease coverage by 6.29%.
Report is 181 commits behind head on main.
The diff coverage is 79.35%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2196      +/-   ##
==========================================
- Coverage   75.38%   69.10%   -6.29%     
==========================================
  Files         100      166      +66     
  Lines        8025    12597    +4572     
==========================================
+ Hits         6050     8705    +2655     
- Misses       1589     3338    +1749     
- Partials      386      554     +168     
Files Changed Coverage Δ
ante/spam_prevention.go 75.92% <ø> (ø)
cmd/ibc_denom/main.go 0.00% <0.00%> (ø)
util/coin/coin.go 12.50% <0.00%> (ø)
x/incentive/codec.go 47.82% <ø> (+9.89%) ⬆️
x/incentive/keeper/invariants.go 0.00% <0.00%> (ø)
x/incentive/keeper/reward.go 82.35% <ø> (ø)
x/incentive/keeper/store.go 70.67% <ø> (ø)
x/incentive/keeper/unbonding.go 80.45% <ø> (ø)
x/incentive/keeper/update.go 52.11% <ø> (ø)
x/incentive/keys.go 100.00% <ø> (ø)
... and 59 more

... and 68 files with indirect coverage changes

@gsk967 gsk967 enabled auto-merge August 14, 2023 13:03
@gsk967 gsk967 added this pull request to the merge queue Aug 14, 2023
Merged via the queue into main with commit debe7b5 Aug 14, 2023
@gsk967 gsk967 deleted the sai/fix_liv_liq_front_end branch August 14, 2023 13:10
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants