Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

fix!: rpc endpoint spelling #2212

Merged
merged 4 commits into from
Aug 29, 2023
Merged

fix!: rpc endpoint spelling #2212

merged 4 commits into from
Aug 29, 2023

Conversation

adamewozniak
Copy link
Collaborator

@adamewozniak adamewozniak commented Aug 29, 2023

Description

Fixes some rpc endpoint spelling


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • added appropriate labels to the PR
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@codecov
Copy link

codecov bot commented Aug 29, 2023

Codecov Report

Merging #2212 (c15fcb1) into main (7f05ad4) will decrease coverage by 5.20%.
Report is 195 commits behind head on main.
The diff coverage is 80.67%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2212      +/-   ##
==========================================
- Coverage   75.38%   70.19%   -5.20%     
==========================================
  Files         100      164      +64     
  Lines        8025    12556    +4531     
==========================================
+ Hits         6050     8814    +2764     
- Misses       1589     3150    +1561     
- Partials      386      592     +206     
Files Changed Coverage Δ
ante/spam_prevention.go 75.92% <ø> (ø)
cmd/ibc_denom/main.go 0.00% <0.00%> (ø)
util/coin/coin.go 12.50% <0.00%> (ø)
x/incentive/codec.go 47.82% <ø> (+9.89%) ⬆️
x/incentive/keeper/invariants.go 0.00% <0.00%> (ø)
x/incentive/keeper/iter.go 84.90% <ø> (ø)
x/incentive/keeper/keeper.go 75.00% <ø> (ø)
x/incentive/keeper/keys.go 95.83% <ø> (ø)
x/incentive/keeper/msg_server.go 80.95% <ø> (ø)
x/incentive/keeper/program.go 56.00% <ø> (ø)
... and 55 more

... and 75 files with indirect coverage changes

@adamewozniak
Copy link
Collaborator Author

The E2E test failing here seems unrelated:

TestE2ETestSuite/TestIBCTokenTransfer/ibc_transfer_quota

Running it again

@adamewozniak adamewozniak added T:Bug A regression or bug in the Umee codebase. C:API C:x/oracle labels Aug 29, 2023
@adamewozniak adamewozniak marked this pull request as ready for review August 29, 2023 16:32
@adamewozniak adamewozniak requested review from a team as code owners August 29, 2023 16:32
@adamewozniak adamewozniak enabled auto-merge August 29, 2023 17:21
@adamewozniak adamewozniak added this pull request to the merge queue Aug 29, 2023
Merged via the queue into main with commit 7e11ea8 Aug 29, 2023
@adamewozniak adamewozniak deleted the woz/misspell branch August 29, 2023 17:23
@@ -72,6 +72,7 @@ Ref: https://keepachangelog.com/en/1.0.0/
- [2148](https://github.com/umee-network/umee/pull/2148) Fix MsgBeginUnbonding counting existing unbondings against max unbond twice.
- [2148](https://github.com/umee-network/umee/pull/2148) Fix MsgLeverageLiquidate CLI not actually allowing wildcard denoms.
- [2197](https://github.com/umee-network/umee/pull/2197) Allowing duplicate symbols on leverage token registry. Fix the oracle voting miss counter on duplicate symbol denoms.
- [2212](https://github.com/umee-network/umee/pull/2212) Fixes an x/oracle RPC endpoint spelling, changing "/umee/oracle/v1/valdiators/{validator_addr}/aggregate_vote" to "/umee/oracle/v1/validators/{validator_addr}/aggregate_vote"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should be also in API Breaking

robert-zaremba pushed a commit that referenced this pull request Aug 30, 2023
* fix: rpc endpoint spelling

* cl++

* proto gen

* cl--
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
C:API C:x/oracle T:Bug A regression or bug in the Umee codebase.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants