Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

style: remove prefix GetCmd from cli #2234

Merged
merged 1 commit into from
Sep 8, 2023

Conversation

pysel
Copy link
Contributor

@pysel pysel commented Sep 8, 2023

Description

closes: #2039

Removes GetCmd prefix from cli commands' builders

@pysel pysel marked this pull request as ready for review September 8, 2023 14:00
@pysel pysel requested review from a team as code owners September 8, 2023 14:00
@codecov
Copy link

codecov bot commented Sep 8, 2023

Codecov Report

Merging #2234 (5362765) into main (7f05ad4) will decrease coverage by 5.16%.
Report is 213 commits behind head on main.
The diff coverage is 79.98%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2234      +/-   ##
==========================================
- Coverage   75.38%   70.23%   -5.16%     
==========================================
  Files         100      168      +68     
  Lines        8025    12619    +4594     
==========================================
+ Hits         6050     8863    +2813     
- Misses       1589     3165    +1576     
- Partials      386      591     +205     
Files Changed Coverage Δ
ante/spam_prevention.go 75.92% <ø> (ø)
cmd/ibc_denom/main.go 0.00% <0.00%> (ø)
util/coin/coin.go 12.50% <0.00%> (ø)
util/sdkutil/msg.go 0.00% <0.00%> (ø)
x/incentive/codec.go 47.82% <ø> (+9.89%) ⬆️
x/incentive/keeper/invariants.go 0.00% <ø> (ø)
x/incentive/keeper/iter.go 84.90% <ø> (ø)
x/incentive/keeper/keeper.go 75.00% <ø> (ø)
x/incentive/keeper/keys.go 95.83% <ø> (ø)
x/incentive/keeper/msg_server.go 80.95% <ø> (ø)
... and 53 more

... and 81 files with indirect coverage changes

📢 Have feedback on the report? Share it here.

@toteki toteki added this pull request to the merge queue Sep 8, 2023
Merged via the queue into umee-network:main with commit d78960b Sep 8, 2023
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

style: remove prefix GetCmd from cli functions
2 participants