Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

feat: max repay on MsgLeveragedLiquidate #2242

Merged
merged 7 commits into from
Sep 14, 2023
Merged

feat: max repay on MsgLeveragedLiquidate #2242

merged 7 commits into from
Sep 14, 2023

Conversation

toteki
Copy link
Member

@toteki toteki commented Sep 13, 2023

No description provided.

@toteki toteki marked this pull request as ready for review September 13, 2023 16:38
@toteki toteki requested a review from a team as a code owner September 13, 2023 16:38
@codecov
Copy link

codecov bot commented Sep 13, 2023 •
edited
Loading

Codecov Report

Merging #2242 (4bb4168) into main (7f05ad4) will decrease coverage by 5.17%.
Report is 220 commits behind head on main.
The diff coverage is 81.45%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2242      +/-   ##
==========================================
- Coverage   75.38%   70.22%   -5.17%     
==========================================
  Files         100      168      +68     
  Lines        8025    12635    +4610     
==========================================
+ Hits         6050     8873    +2823     
- Misses       1589     3167    +1578     
- Partials      386      595     +209
Files Changed Coverage Δ
ante/spam_prevention.go 75.92% <ø> (ø)
cmd/ibc_denom/main.go 0.00% <0.00%> (ø)
util/coin/coin.go 12.50% <0.00%> (ø)
util/sdkutil/msg.go 0.00% <0.00%> (ø)
x/incentive/codec.go 47.82% <ø> (+9.89%) ⬆️
x/incentive/keeper/grpc_query.go 59.18% <ø> (ø)
x/incentive/keeper/hooks.go 50.00% <ø> (ø)
x/incentive/keeper/invariants.go 0.00% <ø> (ø)
x/incentive/keeper/iter.go 84.90% <ø> (ø)
x/incentive/keeper/keeper.go 75.00% <ø> (ø)
... and 51 more

... and 84 files with indirect coverage changes

robert-zaremba
robert-zaremba reviewed Sep 13, 2023
View reviewed changes
Copy link
Member

@robert-zaremba robert-zaremba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you add a test with non zero max liquidation?

@toteki toteki added this pull request to the merge queue Sep 14, 2023
Merged via the queue into main with commit 64171d4 Sep 14, 2023
@toteki toteki deleted the adam/levl branch September 14, 2023 09:10
facundomedica pushed a commit that referenced this pull request Oct 30, 2023
@toteki
feat: max repay on MsgLeveragedLiquidate (#2242)
e8bb546 
* proto and cli

* tx behavior

* lint

* lint

* fix e2d

* nonzero tests
This was referenced Apr 19, 2024
Merged
Merged
Merged
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@robert-zaremba robert-zaremba robert-zaremba approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@toteki @robert-zaremba