Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

feat: account summary to display both spot and leverage prices #2263

Merged
merged 13 commits into from
Sep 27, 2023
Merged

feat: account summary to display both spot and leverage prices #2263

merged 13 commits into from
Sep 27, 2023

Conversation

toteki
Copy link
Member

@toteki toteki commented Sep 22, 2023

No description provided.

@codecov
Copy link

codecov bot commented Sep 22, 2023 •
edited
Loading

Codecov Report

Merging #2263 (70709f5) into main (7f05ad4) will decrease coverage by 5.17%.
Report is 246 commits behind head on main.
The diff coverage is 83.60%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2263      +/-   ##
==========================================
- Coverage   75.38%   70.22%   -5.17%     
==========================================
  Files         100      169      +69     
  Lines        8025    12800    +4775     
==========================================
+ Hits         6050     8989    +2939     
- Misses       1589     3208    +1619     
- Partials      386      603     +217
Files Coverage Δ
ante/ante.go 66.66% <100.00%> (+18.45%) ⬆️
ante/fee.go 80.00% <100.00%> (+1.64%) ⬆️
ante/spam_prevention.go 75.92% <ø> (ø)
app/inflation/inflation.go 100.00% <100.00%> (ø)
util/coin/utoken.go 100.00% <100.00%> (ø)
x/incentive/client/tests/suite.go 100.00% <100.00%> (ø)
x/incentive/client/tests/tests.go 100.00% <100.00%> (ø)
x/incentive/codec.go 47.82% <ø> (+9.89%) ⬆️
x/incentive/genesis.go 92.48% <100.00%> (+79.14%) ⬆️
x/incentive/keeper/bond.go 92.50% <ø> (ø)
... and 48 more

... and 89 files with indirect coverage changes

@toteki toteki marked this pull request as ready for review September 25, 2023 05:45
@toteki toteki requested a review from a team as a code owner September 25, 2023 05:45
robert-zaremba
robert-zaremba approved these changes Sep 26, 2023
View reviewed changes
Copy link
Member

@robert-zaremba robert-zaremba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

toteki and others added 2 commits September 26, 2023 07:02
@toteki @robert-zaremba
suggestion++
3cae2c4 
Co-authored-by: Robert Zaremba <robert@zaremba.ch>
@toteki
Merge branch 'main' into adam/display
186a88d
@toteki toteki enabled auto-merge September 26, 2023 13:02
@toteki toteki added this pull request to the merge queue Sep 27, 2023
Merged via the queue into main with commit 8fe5d42 Sep 27, 2023
@toteki toteki deleted the adam/display branch September 27, 2023 17:35
facundomedica pushed a commit that referenced this pull request Oct 30, 2023
@toteki @robert-zaremba
feat: account summary to display both spot and leverage prices (#2263)
be01797 
* add inspectAccount query

* --

* --

* unstable field note

* new query fields and logic

* fix tests

* suggestion++

Co-authored-by: Robert Zaremba <robert@zaremba.ch>

* fix suggestion

* cl++

---------

Co-authored-by: Robert Zaremba <robert@zaremba.ch>
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@robert-zaremba robert-zaremba robert-zaremba approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@toteki @robert-zaremba