Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

feat(uibc): quota reset event #2264

Merged
merged 4 commits into from
Sep 26, 2023
Merged

feat(uibc): quota reset event #2264

merged 4 commits into from
Sep 26, 2023

Conversation

robert-zaremba
Copy link
Member

Description

We should log important state changes.
Using the traditional event method, to not create a new object type now.

@robert-zaremba robert-zaremba added the skip-e2e-test Skip the e2e tests label Sep 25, 2023
@robert-zaremba robert-zaremba requested a review from a team as a code owner September 25, 2023 18:03
@codecov
Copy link

codecov bot commented Sep 25, 2023

Codecov Report

Merging #2264 (a459e7e) into main (7f05ad4) will decrease coverage by 4.99%.
Report is 242 commits behind head on main.
The diff coverage is 83.60%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2264      +/-   ##
==========================================
- Coverage   75.38%   70.40%   -4.99%     
==========================================
  Files         100      168      +68     
  Lines        8025    12644    +4619     
==========================================
+ Hits         6050     8902    +2852     
- Misses       1589     3143    +1554     
- Partials      386      599     +213     
Files Coverage Δ
ante/ante.go 66.66% <100.00%> (+18.45%) ⬆️
ante/fee.go 80.00% <100.00%> (+1.64%) ⬆️
ante/spam_prevention.go 75.92% <ø> (ø)
app/inflation/inflation.go 100.00% <100.00%> (ø)
util/coin/utoken.go 100.00% <100.00%> (ø)
x/incentive/client/tests/suite.go 100.00% <100.00%> (ø)
x/incentive/client/tests/tests.go 100.00% <100.00%> (ø)
x/incentive/codec.go 47.82% <ø> (+9.89%) ⬆️
x/incentive/genesis.go 92.48% <100.00%> (+79.14%) ⬆️
x/incentive/keeper/bond.go 92.50% <ø> (ø)
... and 49 more

... and 86 files with indirect coverage changes

Copy link
Collaborator

@gsk967 gsk967 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@robert-zaremba robert-zaremba added this pull request to the merge queue Sep 26, 2023
Merged via the queue into main with commit 5596d9f Sep 26, 2023
@robert-zaremba robert-zaremba deleted the robert/ibcquota-log branch September 26, 2023 09:43
facundomedica pushed a commit that referenced this pull request Oct 30, 2023
* feat(uibc): quota reset log

* emit event

* type update
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
skip-e2e-test Skip the e2e tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants