chore: change consensus.block.max_size to 4 MB #2288
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robert-zaremba
changed the title
Codecov Report
@@ Coverage Diff @@
## main #2288 +/- ##
==========================================
- Coverage 75.38% 70.49% -4.90%
==========================================
Files 100 170 +70
Lines 8025 12882 +4857
==========================================
+ Hits 6050 9081 +3031
- Misses 1589 3198 +1609
- Partials 386 603 +217
|
toteki
approved these changes
Oct 17, 2023
robert-zaremba
changed the title
facundomedica
pushed a commit
that referenced
this pull request
Oct 30, 2023
* chore: change consensus.block.max_size to 10MB * added more notes * changelog * update release notes and changelog * release notes: validator notes --------- Co-authored-by: Adam Moser <63419657+toteki@users.noreply.github.com>
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
As per Amulet team analysis, the existing 21MB block size may expose security risk and teams should consider reducing it. In this PR we reduce it to 4 MB, giving enough room for Cosmowasm deployments and big transactions. Blocks full of oracle txs are less than 40kB.