feat: v6.3 upgrade handler and release notes #2376
Conversation
WalkthroughThe recent update to version v6.3.0 brings enhancements and new features to the system. It includes parameter modifications, additional queries, and a fix in calculation logic. A new handler is added but remains disabled, and a significant upgrade is made to the Cosmos SDK. The upgrade process itself has been refined with changes to the registration methods to better manage new versions. Changes
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChat with CodeRabbit Bot (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Review Status
Actionable comments generated: 0
Configuration used: CodeRabbit UI
Files selected for processing (4)
- CHANGELOG.md (1 hunks)
- README.md (1 hunks)
- RELEASE_NOTES.md (1 hunks)
- app/upgrades.go (2 hunks)
Additional comments: 11
RELEASE_NOTES.md (2)
9-16: The release notes for v6.3.0 correctly summarize the key updates and new features introduced in this version, including the Cosmos SDK patch update, new queries, message type updates, and response enhancements.
22-22: The upgrade title for Cosmovisor is correctly set to "v6.3" to match the new version release.
README.md (2)
64-64: The Release Compatibility Matrix has been updated to include the new version v6.3.x along with its corresponding dependencies, ensuring users are aware of the compatible versions.
68-68: The Price Feeder repository link has been updated to point to the new recommended oracle price feeder repository, aligning with the PR objectives.
app/upgrades.go (2)
59-62: The
RegisterUpgradeHandlersmethod has been updated with the renaming ofregisterUpgrade6toregisterUpgrade6_0and the addition of a new method for "v6.3", which aligns with the PR objectives for handling the new upgrade logic.65-65: The
registerUpgrade6_2method has been updated internally to handle the upgrade logic, with no changes to the method signature, which is consistent with the PR objectives.CHANGELOG.md (5)
49-67: The changelog for version
v6.3.0is well-documented, with clear references to pull requests for each change. It's important to ensure that all listed changes correspond to actual merged PRs and that the descriptions accurately reflect the changes made in those PRs.49-67: The structure of the changelog entries is consistent with the guiding principles provided at the beginning of the file, which is good for maintainability and readability.
49-67: The grouping of changelog entries by type (Improvements, Features, Bug Fixes) is a best practice that enhances the readability and organization of the document.
49-49: Including the release date for version
v6.3.0is a good practice for historical tracking and should always be included in version entries.67-67: The changelog entry for the bug fix related to inflow amount calculation provides critical information for users who might have been affected by this issue, ensuring transparency and trust in the release notes.
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #2376 +/- ##
==========================================
- Coverage 75.38% 70.03% -5.36%
==========================================
Files 100 174 +74
Lines 8025 13027 +5002
==========================================
+ Hits 6050 9123 +3073
- Misses 1589 3299 +1710
- Partials 386 605 +219
|
There was a problem hiding this comment.
Review Status
Actionable comments generated: 0
Configuration used: CodeRabbit UI
Files selected for processing (2)
- CHANGELOG.md (1 hunks)
- app/upgrades.go (3 hunks)
Files skipped from review as they are similar to previous changes (2)
- CHANGELOG.md
- app/upgrades.go
Co-authored-by: Sai Kumar <17549398+gsk967@users.noreply.github.com> Co-authored-by: Adam Moser <63419657+toteki@users.noreply.github.com>
There was a problem hiding this comment.
Review Status
Actionable comments generated: 2
Configuration used: CodeRabbit UI
Files selected for processing (4)
- CHANGELOG.md (1 hunks)
- RELEASE_NOTES.md (1 hunks)
- sdkclient/tx/client.go (1 hunks)
- tests/e2e/setup/utils.go (2 hunks)
Files skipped from review as they are similar to previous changes (2)
- CHANGELOG.md
- RELEASE_NOTES.md
Additional comments: 1
tests/e2e/setup/utils.go (1)
- 297-297: The retry limit in the
BroadcastTxWithRetryfunction has been reduced. Ensure that this change does not negatively impact the reliability of transaction broadcasting, especially in environments with high latency or network instability.
Summary by CodeRabbit
New Features
outflowsentry.uibc/MissCountersanduibc/Inflows.leverage/RegisteredTokenMarketsto fetch Registered Tokens and their Market Summaries for frontend in fewer queries.Improvements
uic/MsgGovUpdateQuotatouibc/MsgGovUpdateQuota.Bug Fixes
Documentation