-
Notifications
You must be signed in to change notification settings - Fork 161
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
fix(ugov amino): don't use proto.MessageName #2473
Conversation
WalkthroughThe changes involve updates to the Changes
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2473 +/- ##
==========================================
- Coverage 75.38% 69.38% -6.01%
==========================================
Files 100 185 +85
Lines 8025 10909 +2884
==========================================
+ Hits 6050 7569 +1519
- Misses 1589 2712 +1123
- Partials 386 628 +242
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Review Status
Actionable comments generated: 0
Configuration used: CodeRabbit UI
Files selected for processing (2)
- x/auction/codec.go (1 hunks)
- x/ugov/codec.go (2 hunks)
Additional comments: 3
x/auction/codec.go (1)
- 25-25: The updated comment accurately reflects the registration of interfaces and concrete types specific to the
x/auction
package, enhancing the clarity and maintainability of the code.x/ugov/codec.go (2)
- 27-27: The update to the comment corrects the package reference from
x/uibc
tox/ugov
, aligning with the PR's objective to enhance documentation accuracy.- 31-31: The change in message type registration to use explicit string values instead of
proto.MessageName
aligns with the PR's objectives to enhance code reliability and clarity.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Review Status
Actionable comments generated: 1
Configuration used: CodeRabbit UI
Files selected for processing (1)
- CHANGELOG.md (2 hunks)
Additional comments: 1
CHANGELOG.md (1)
- 63-63: The update related to
MaxModuleWithdraw
for computing userMaxWithdraw
is clearly documented and accurate.
|
||
### Bug Fixes | ||
|
||
- [2473](https://github.com/umee-network/umee/pull/2462) Correct x/ugov Amino registration for x/ugov messages (they don't have MessageName option). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The PR link provided for the correction in x/ugov Amino registration (2473) seems to be incorrect and points to PR 2462 instead. Please update it to the correct PR link for accuracy.
Description
Summary by CodeRabbit