Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

fix: enable ledger support #517

Merged
merged 2 commits into from
Feb 7, 2022
Merged

fix: enable ledger support #517

merged 2 commits into from
Feb 7, 2022

Conversation

alexanderbez
Copy link
Contributor

@alexanderbez alexanderbez commented Feb 7, 2022

Description

  • Fix makefile build and install targets to support Ledger devices.

Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added appropriate labels to the PR
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@alexanderbez alexanderbez merged commit 8df1692 into main Feb 7, 2022
@alexanderbez alexanderbez deleted the bez/fix-ledger-build branch February 7, 2022 23:14
mergify bot pushed a commit that referenced this pull request Feb 7, 2022
(cherry picked from commit 8df1692)

# Conflicts:
#	CHANGELOG.md
mergify bot pushed a commit that referenced this pull request Feb 7, 2022
(cherry picked from commit 8df1692)
alexanderbez added a commit that referenced this pull request Feb 7, 2022
(cherry picked from commit 8df1692)

Co-authored-by: Aleksandr Bezobchuk <alexanderbez@users.noreply.github.com>
alexanderbez added a commit that referenced this pull request Feb 7, 2022
* fix: enable ledger support (#517)

(cherry picked from commit 8df1692)

# Conflicts:
#	CHANGELOG.md

* cl++

Co-authored-by: Aleksandr Bezobchuk <alexanderbez@users.noreply.github.com>
Co-authored-by: Aleksandr Bezobchuk <aleks.bezobchuk@gmail.com>
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant