Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

test: x/oracle unit test cleanup #781

Merged
merged 5 commits into from
Apr 7, 2022
Merged

test: x/oracle unit test cleanup #781

merged 5 commits into from
Apr 7, 2022

Conversation

adamewozniak
Copy link
Collaborator

Description

Just cleanup + minor additions to our oracle module unit tests

progress on: #661


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added appropriate labels to the PR
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@codecov-commenter
Copy link

codecov-commenter commented Apr 7, 2022

Codecov Report

Merging #781 (ec7e927) into main (a176fb2) will decrease coverage by 0.32%.
The diff coverage is 13.19%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #781      +/-   ##
==========================================
- Coverage   48.03%   47.70%   -0.33%     
==========================================
  Files          64       64              
  Lines        9329     9426      +97     
==========================================
+ Hits         4481     4497      +16     
- Misses       4581     4662      +81     
  Partials      267      267              
Impacted Files Coverage Δ
ante/fee.go 93.61% <ø> (ø)
ante/spam_prevention.go 61.76% <ø> (ø)
x/ibctransfer/keeper/keeper.go 77.92% <ø> (ø)
x/leverage/abci.go 0.00% <ø> (ø)
x/leverage/client/cli/proposal.go 72.72% <ø> (ø)
x/leverage/client/cli/query.go 0.00% <ø> (ø)
x/leverage/client/cli/tx.go 0.00% <ø> (ø)
x/leverage/client/tests/suite.go 100.00% <ø> (ø)
x/leverage/client/tests/util.go 87.69% <ø> (ø)
x/leverage/genesis.go 50.00% <ø> (ø)
... and 36 more

@adamewozniak adamewozniak marked this pull request as ready for review April 7, 2022 21:11
@adamewozniak adamewozniak requested a review from a team as a code owner April 7, 2022 21:11
@adamewozniak adamewozniak merged commit 298272a into main Apr 7, 2022
@adamewozniak adamewozniak deleted the woz/oracle-tests branch April 7, 2022 22:00
mergify bot pushed a commit that referenced this pull request Apr 7, 2022
adamewozniak added a commit that referenced this pull request Apr 8, 2022
(cherry picked from commit 298272a)

Co-authored-by: Adam Wozniak <29418299+adamewozniak@users.noreply.github.com>
# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants