Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

ci: Fixes protobuf linting and compliation #935

Merged
merged 24 commits into from
May 26, 2022
Merged

ci: Fixes protobuf linting and compliation #935

merged 24 commits into from
May 26, 2022

Conversation

brianosaurus
Copy link
Contributor

@brianosaurus brianosaurus commented May 20, 2022 •
edited
Loading

Description

Our protobuf linting was preventing our builds from turning 100% green in our checks.

Closes #796

Author Checklist

  • included the correct type prefix in the PR title
  • added appropriate labels to the PR
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • added a changelog entry to CHANGELOG.md
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@brianosaurus brianosaurus requested a review from a team as a code owner May 20, 2022 19:20
@brianosaurus brianosaurus self-assigned this May 20, 2022
@brianosaurus @toteki
Update proto/cosmos/base/coin.proto
d84e7ed 
Co-authored-by: toteki <63419657+toteki@users.noreply.github.com>
adamewozniak
adamewozniak requested changes May 20, 2022
View reviewed changes
@brianosaurus brianosaurus requested a review from a team as a code owner May 20, 2022 21:17
brianosaurus and others added 2 commits May 20, 2022 15:20
@brianosaurus @adamewozniak
Update proto/umee/leverage/v1/gov.proto
a3e7810 
Co-authored-by: Adam Wozniak <29418299+adamewozniak@users.noreply.github.com>
@brianosaurus @adamewozniak
Update proto/umee/leverage/v1/leverage.proto
6a7ee68 
Co-authored-by: Adam Wozniak <29418299+adamewozniak@users.noreply.github.com>
@brianosaurus brianosaurus force-pushed the brianosaurus/fix-proto-linting branch from 0682328 to 6a7ee68 Compare May 21, 2022 22:26
@brianosaurus brianosaurus requested a review from adamewozniak May 21, 2022 23:18
toteki
toteki requested changes May 23, 2022
View reviewed changes
Copy link
Member

@toteki toteki left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There should (hopefully) be a way to do this with a smaller diff

@brianosaurus brianosaurus force-pushed the brianosaurus/fix-proto-linting branch from bda0735 to 750049f Compare May 24, 2022 04:39
toteki
toteki reviewed May 24, 2022
View reviewed changes
@toteki toteki changed the title chore: Fixes protobuf linting and compliation ci: Fixes protobuf linting and compliation May 24, 2022
@brianosaurus brianosaurus force-pushed the brianosaurus/fix-proto-linting branch from d2a1f4c to d451392 Compare May 24, 2022 15:56
adamewozniak
adamewozniak reviewed May 24, 2022
View reviewed changes
Copy link
Collaborator

@adamewozniak adamewozniak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple nitpicks & questions but nice work @brianosaurus this is looking great 🚀

@brianosaurus
Fixes proto-breaking check
8311787 
Migrated buf to v1
removes third_party from .gitignore
Removing unused scripts
@brianosaurus brianosaurus force-pushed the brianosaurus/fix-proto-linting branch from 949b611 to 8311787 Compare May 24, 2022 23:50
toteki
toteki reviewed May 25, 2022
View reviewed changes
toteki
toteki reviewed May 25, 2022
View reviewed changes
toteki
toteki approved these changes May 25, 2022
View reviewed changes
Copy link
Member

@toteki toteki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems legit

brianosaurus and others added 3 commits May 24, 2022 21:33
@brianosaurus @toteki
Update buf.work.yaml
9b159b1 
Co-authored-by: toteki <63419657+toteki@users.noreply.github.com>
@brianosaurus @toteki
Update proto/buf.yaml
f2373b8 
Co-authored-by: toteki <63419657+toteki@users.noreply.github.com>
@brianosaurus
Removing third_party from Makefile
d9df32c
adamewozniak
adamewozniak approved these changes May 25, 2022
View reviewed changes
Copy link
Collaborator

@adamewozniak adamewozniak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Super legit

robert-zaremba
robert-zaremba reviewed May 25, 2022
View reviewed changes
Copy link
Member

@robert-zaremba robert-zaremba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a README file to the proto directory to document how the buf is used

@brianosaurus brianosaurus force-pushed the brianosaurus/fix-proto-linting branch from fcb135f to 3bf0b42 Compare May 25, 2022 21:56
@brianosaurus brianosaurus force-pushed the brianosaurus/fix-proto-linting branch from 8e677b6 to 3173fd6 Compare May 25, 2022 22:23
@brianosaurus brianosaurus mentioned this pull request May 25, 2022
Closed
4 tasks
@brianosaurus brianosaurus merged commit 2bba354 into main May 26, 2022
@brianosaurus brianosaurus deleted the brianosaurus/fix-proto-linting branch May 26, 2022 03:05
This was referenced Apr 19, 2024
Merged
Merged
Merged
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@robert-zaremba robert-zaremba robert-zaremba left review comments

@adamewozniak adamewozniak adamewozniak approved these changes

@toteki toteki toteki approved these changes

Assignees

@brianosaurus brianosaurus

Labels
C:Tools P:Low T:CI
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

proto CI fails
4 participants
@brianosaurus @toteki @robert-zaremba @adamewozniak