Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

feat:add online solution links for qiankun #2754

Open
wants to merge 7 commits into
base: next
Choose a base branch
from

Conversation

gjmhandsome
Copy link

Description of change
  • close #2686提供在线的解决方案链接
  • 新增.dumi/pages/error目录,约定式路由。
  • 修改packages/shared/src/error/QiankunError.ts
  • .dumirc.ts增加配置项style

@changeset-bot
Copy link

changeset-bot bot commented Oct 23, 2023

🦋 Changeset detected

Latest commit: 43a31d3

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 5 packages
Name Type
@qiankunjs/shared Patch
@qiankunjs/loader Patch
qiankun Patch
@qiankunjs/sandbox Patch
@qiankunjs/react Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel
Copy link

vercel bot commented Oct 23, 2023

@gjmhandsome is attempting to deploy a commit to a Personal Account owned by @umijs on Vercel.

@umijs first needs to authorize it.

@kuitos
Copy link
Member

kuitos commented Oct 24, 2023

Nice~ 来一个 demo 截图?

@gjmhandsome
Copy link
Author

Nice~ 来一个 demo 截图?

image

@gjmhandsome gjmhandsome reopened this Oct 25, 2023
@kuitos
Copy link
Member

kuitos commented Nov 2, 2023

CI 挂了,prettier 的问题 @gjmhandsome

@kuitos
Copy link
Member

kuitos commented Nov 8, 2023

其他包使用的地方一起改一下吧,不然ci过不了

@gjmhandsome
Copy link
Author

其他包使用的地方一起改一下吧,不然ci过不了

@kuitos 再试下

packages/shared/src/error/QiankunError.ts Outdated Show resolved Hide resolved
.dumi/pages/error/index.tsx Outdated Show resolved Hide resolved
@kuitos
Copy link
Member

kuitos commented Nov 17, 2023

@gjmhandsome ping

@gjmhandsome
Copy link
Author

@gjmhandsome ping

ok,今晚回去搞

@gjmhandsome
Copy link
Author

@gjmhandsome ping

@kuitos 再看下

@kuitos
Copy link
Member

kuitos commented Nov 23, 2023

Nice~ 不过新的官网还没上线,这个 pr 现在还不能合,不然就会出现 error message 里出现不能访问的链接了。等新官网上线了我来处理下

@kuitos
Copy link
Member

kuitos commented Dec 13, 2023

@gjmhandsome 可以加下我微信 kuitos_L ,我拉你进贡献者群

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants