New option: --openai.apibase [$OPENAI_API_BASE]
#135
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
umputun
reviewed
Oct 10, 2024
lib/tgspam/openai.go
Outdated
| @@ -22,6 +22,7 @@ type openAIChecker struct { | |||
|
|
|||
| // OpenAIConfig contains parameters for openAIChecker | |||
| type OpenAIConfig struct { | |||
| BaseURL string | |||
There was a problem hiding this comment.
is there a reason why we even need this new field here? from what I see, the only place you should set it is in main.go makeDetector (which you did), but I can't understand why it is added here too.
…without --openai.token Motivation: some services can work without apikey (token)
johnd0e
force-pushed
the
openai-apibase
branch
from
fcca3c7 to
1a5b3c1
Compare
johnd0e
force-pushed
the
openai-apibase
branch
from
1a5b3c1 to
ae753ca
Compare
|
So this change will make it possible to use custom self-hosted endpoints assuming they have OpenAI compatible APIs, am I right? |
|
@georg3k |
umputun
added a commit
that referenced
this pull request
Oct 26, 2024
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
OpenAI integration can be activated by specifying
--openai.apibase, even without the--openai.token, since some services may function without an API key (token).Additionally:
gpt-4o-mini.Please ignore any changes that are not directly relevant.
Warning
As I am not a Go programmer, please ensure that the suggested changes are correct.