-
-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
feat: add GITLAB_COMMENT_TYPE
env variable to use discussions or notes
#98
Conversation
|
🦋 Changeset detectedLatest commit: f0b4ceb The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
Just curious, why not just resolve the thread if you want to merge? |
It creates an extra step that isn't needed, and makes it impossible to auto-merge MR from bots (e.g renovate). |
Thanks for explain! I didn't use auto-merge MR from bots in GitLab. I think this PR is acceptable. |
COMMENT_TYPE
env variable to use discussions or notesGITLAB_COMMENT_TYPE
env variable to use discussions or notes
This PR adds a new
COMMENT_TYPE
environment variable, to control the type of comment created when usingchangesets-gitlab comment
:discussion
creates a new discussion (thread). This is the defaultnote
creates a note (comment)This is useful when a GitLab repo requires all threads to be resolved before merging an MR. We can instead use this new
note
COMMENT_TYPE
which won't block merging.