Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

perf: Set the EasyCom option type to optional #121

Merged
merged 1 commit into from
Dec 21, 2023

Conversation

Ares-Chang
Copy link
Member

@Ares-Chang Ares-Chang commented Dec 21, 2023

perf #120 ,增加 easycom 内配置项 ts 类型可选

Summary by CodeRabbit

  • Refactor
    • Updated the configuration options to allow more flexibility. Optional settings for automatic scanning and custom configurations are now available.

@Ares-Chang Ares-Chang requested a review from KeJunMao December 21, 2023 02:14
Copy link

coderabbitai bot commented Dec 21, 2023

Walkthrough

The EasyCom interface in the configuration types has been updated to make the autoscan and custom properties optional. This change will allow for more flexible configurations, as these properties can now be omitted without causing type errors.

Changes

File Path Change Summary
.../config/types/easycom.ts Made autoscan and custom properties of EasyCom interface optional.

🐇✨
In the land of code, changes small,
A rabbit tweaked the types with gall.
Now autoscan and custom may retreat,
For in optionals, they've found their seat. 🌱

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on X ?


Tips

Chat with CodeRabbit Bot (@coderabbitai)

  • You can reply to a review comment made by CodeRabbit.
  • You can tag CodeRabbit on specific lines of code or files in the PR by tagging @coderabbitai in a comment.
  • You can tag @coderabbitai in a PR comment and ask one-off questions about the PR and the codebase. Use quoted replies to pass the context for follow-up questions.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • The JSON schema for the configuration file is available here.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review Status

Actionable comments generated: 0

Configuration used: CodeRabbit UI

Commits Files that changed from the base of the PR and between 738d570 and 38330ef.
Files selected for processing (1)
  • packages/core/src/config/types/easycom.ts (1 hunks)
Additional comments: 2
packages/core/src/config/types/easycom.ts (2)
  • 2-3: The syntax for making autoscan and custom optional is correct and aligns with the PR's objective to enhance flexibility in the EasyCom configuration.

  • 2-3: Ensure that all parts of the codebase that implement or interact with the EasyCom interface are updated to handle these properties being optional. This may involve checking for undefined values and providing default behaviors if necessary.

@KeJunMao KeJunMao linked an issue Dec 21, 2023 that may be closed by this pull request
4 tasks
@KeJunMao KeJunMao merged commit dc9f529 into uni-helper:main Dec 21, 2023
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

easycomautoscan 属性类型需要修改为可选
2 participants