fix(core): fix subPackage cannot match the second-level dir

[skiyee]

fixes: #152

Summary by CodeRabbit

• New Features

  • Introduced new About and Home pages for both 'sub-activity' and 'sub-main' sections in the playground package, enhancing navigation and user interaction.

• Bug Fixes

  • Improved the routing calculation in PageContext to ensure accurate path generation based on the project structure, enhancing reliability.

• Tests

  • Added new test case to address and fix the sub-package matching issue for second-level directories, ensuring robust functionality.

[coderabbitai]

Walkthrough

The update primarily involves adjusting path calculations in the PageContext class to better handle sub-package directories, alongside adding simple templates for new vue files in various sub-pages. A test case was also introduced to ensure correct path matching for sub-packages in nested directories.

Changes

File Path	Change Summary
packages/core/src/context.ts	Modified path calculation to incorporate basePath derived from project options.
packages/playground/src/.../about/index.vue	Added new vue files in about sub-pages across sub-activity and sub-main directories.
packages/playground/src/.../home/index.vue	Added new vue files in home sub-pages across sub-activity and sub-main directories.
test/generate.spec.ts	Added it function import and a new test case to fix sub-package path matching for nested dirs.

Assessment against linked issues

Objective	Addressed	Explanation
Support sub-packages in pages directory (#152)	✅

Poem

🐇 Ode to the Code Update 🌟

In the burrows of the code, deep and wide,
Paths intertwine where sub-packages reside.
A rabbit hops through, with a fix in its stride,
Now all can nest, in pages with pride.
Cheers to the paths, now correctly allied!

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai generate interesting stats about this repository and render them as a table.
  • @coderabbitai show all the console.log statements in this repository.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 0

Review Details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between c46d28e and d5a83df.

Files selected for processing (6)

• packages/core/src/context.ts (1 hunks)
• packages/playground/src/pages-sub-pages/sub-activity/pages/about/index.vue (1 hunks)
• packages/playground/src/pages-sub-pages/sub-activity/pages/home/index.vue (1 hunks)
• packages/playground/src/pages-sub-pages/sub-main/pages/about/index.vue (1 hunks)
• packages/playground/src/pages-sub-pages/sub-main/pages/home/index.vue (1 hunks)
• test/generate.spec.ts (2 hunks)

Files skipped from review due to trivial changes (4)

• packages/playground/src/pages-sub-pages/sub-activity/pages/about/index.vue
• packages/playground/src/pages-sub-pages/sub-activity/pages/home/index.vue
• packages/playground/src/pages-sub-pages/sub-main/pages/about/index.vue
• packages/playground/src/pages-sub-pages/sub-main/pages/home/index.vue

Additional comments not posted (2)

test/generate.spec.ts (1)

176-216: Ensure the new test case is comprehensive and correctly tests the subpackage path resolution.

packages/core/src/context.ts (1)

244-245: Ensure the new path calculation logic correctly resolves subpackage paths.

[ModyQyW]

LGTM

[Shigukj]

正是我需要的

[wukongkong]

感谢~

[ModyQyW]

如果没有进一步需要修改的反馈，我计划在明天合并并发布该 PR

[ModyQyW]

Thank you!

[DuduStyle]

新的配置规则是什么？没看明白？
subPackages: ['src/sub-pages', 'src/sub-pages/report'],
此类配置形式，sub-pages分包的内容里依然包含report路由 @ModyQyW @skiyee

[skiyee]

该配置是指定某个文件夹让其成为分包的

如果把 src/sub-pages 当成分包，那么此时在该文件夹下的 视图文件(无论在哪个层级) 都会被当作 “页面”

PS: 建议不要在分包内再嵌套分包