Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

OptionalColorNormalMesh writes no color when normals are missing (PLY-Format) #100

Closed
Andreas-Forster opened this issue Apr 6, 2018 · 0 comments
Closed

OptionalColorNormalMesh writes no color when normals are missing (PLY-Format) #100

Andreas-Forster opened this issue Apr 6, 2018 · 0 comments
Labels
bug

Comments

@Andreas-Forster
Copy link
Member

When an OptionalColorNormalMesh is passed to scalismo.faces.MeshIO.write without having normals then only the shape is written to the file.

  val shape: TriangleMesh3D = ???
  val color: Option[TextureMappedProperty[RGBA]] = ???
  val mesh = OptionalColorNormalMesh3D(shape,color,None)
  MeshIO.write(mesh, new File("/tmp/a.ply"))

However, it would be easily possible to calculate normals from the shape and use them. As a user, it is not obvious that the color/texture is not written just because there are the normals missing. I consider this a bug, otherwise, we should not expose the interface taking an OptionalColorNormalMesh.
andreas-schneider pushed a commit that referenced this issue Apr 6, 2018
Merge pull request #101 from unibas-gravis/fixColorNotWrittenForMissi…
6e2dfc9 
…ngNormals

Fixes  #100 bug in MeshIO when writing OptionalColorNormalMesh without normals but with color
# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Andreas-Forster