Skip to content

Commit

Permalink
ICU-22298 Include <utility> in measunit.h
Browse files Browse the repository at this point in the history
measunit.h uses std::pair, std::make_pair, and std::move, all of which
are declared in the <utility> header. This still compiles because many
implementations of the C++ standard library have <utility> as a
transitive dependency of other C++ standard library headers; however,
these transitive includes are not guaranteed to exist and will not exist
in some contexts (e.g. building against LLVM's libc++ with -fmodules).
  • Loading branch information
alanzhao1 authored and markusicu committed Mar 15, 2023
1 parent 2d9fa3f commit 7ed7d42
Showing 1 changed file with 1 addition and 0 deletions.
1 change: 1 addition & 0 deletions icu4c/source/i18n/unicode/measunit.h
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,7 @@

#if !UCONFIG_NO_FORMATTING

#include <utility>
#include "unicode/unistr.h"
#include "unicode/localpointer.h"

Expand Down

1 comment on commit 7ed7d42

@github-actions
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Performance Alert ⚠️

Possible performance regression was detected for benchmark.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold 2.

Benchmark suite Current: 7ed7d42 Previous: 2d9fa3f Ratio
TestAssign2 50.3199 ns/iter 25.004 ns/iter 2.01

This comment was automatically generated by workflow using github-action-benchmark.

Please # to comment.