-
-
Notifications
You must be signed in to change notification settings - Fork 771
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
ICU-22112 word break updates for @,colon; colon tailorings for fi,sv #2159
ICU-22112 word break updates for @,colon; colon tailorings for fi,sv #2159
Conversation
/azp run CI-Exhaustive |
Azure Pipelines successfully started running 1 pipeline(s). |
Hmm, failures on MSVC and Cygwin for C, likely the non-ASCII in the MidLetter set, will change to \u notation (not necessary for J but changing there too for consistency) |
5808ced
to
1679750
Compare
Hooray! The files in the branch are the same across the force-push. 😃 ~ Your Friendly Jira-GitHub PR Checker Bot |
/azp run CI-Exhaustive |
Azure Pipelines successfully started running 1 pipeline(s). |
And that did fix the MSVC etc. failures. |
@macchiati @richgillam Thanks for prior approvals, I had to fix CI build failures on MSVC due to the non-ASCII colons in the MidLetter set removals, changed to using \uNNNN notation. Please re-approve when you have a chance... Actually wait, there is now a merge conflict I need to resolve. |
a2e8712
to
b8c6de9
Compare
Hooray! The files in the branch are the same across the force-push. 😃 ~ Your Friendly Jira-GitHub PR Checker Bot |
/azp run CI-Exhaustive |
Azure Pipelines successfully started running 1 pipeline(s). |
@macchiati @richgillam Thanks for prior approvals, I had to fix CI build failures on MSVC due to the non-ASCII colons in the MidLetter set removals, changed to using \uNNNN notation, then I had to resolve a merge conflict (just rebuilding the jars). Please re-approve when you have a chance... (now ready) |
we now got complain from chrome users on this https://bugs.chromium.org/p/chromium/issues/detail?id=1410331 |
@FrankYFTang That is interesting, since the change was initially promoted by Google, see https://unicode-org.atlassian.net/browse/CLDR-15767 |
hum? who from Google lobby for that? |
@FrankYFTang Mark and Markus as I recall. This was not something that came from me, or from Apple. |
This is covered by Chromium bug 1410331. The problem in Chromium was that we already had a local patch to break at Previously in Chromium, Given that the problematic breaking in Chromium was triggered by the interaction of ICU’s new don’t-break-at- word_POSIX.txt appears to have the same behavior as Chromium of breaking at Chromium’s break-at- |
…tter for wordbreak, update tests
…tter for wordbreak, update tests
…tter for wordbreak, update tests (cherry picked from commit 5618203)
…rdbreak, update tests (cherry picked from commit 5618203)
…tter for wordbreak, update tests
Checklist
Word break updates:
fi
andsv
that keep colons in MidLetter class