Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Fix or remove binary search code in icu_provider_baked #6164

Open
sffc opened this issue Feb 19, 2025 · 0 comments
Open

Fix or remove binary search code in icu_provider_baked #6164

sffc opened this issue Feb 19, 2025 · 0 comments
Labels
C-data-infra Component: provider, datagen, fallback, adapters T-techdebt Type: ICU4X code health and tech debt

Comments

@sffc
Copy link
Member

sffc commented Feb 19, 2025

icu_provider_baked has two modes internally: a zerotrie mode (used in 2.0-beta) and a binary search mode (used in 1.x).

The code for binary search is currently #[allow(dead_code)], and it has drifted stale with changes such as #6133.

@sffc sffc added C-data-infra Component: provider, datagen, fallback, adapters T-techdebt Type: ICU4X code health and tech debt labels Feb 19, 2025
sffc added a commit to sffc/omnicu that referenced this issue Feb 19, 2025
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
C-data-infra Component: provider, datagen, fallback, adapters T-techdebt Type: ICU4X code health and tech debt
Projects
None yet
Development

No branches or pull requests

1 participant