Skip to content

Support KS X 1026-1 #92

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Support KS X 1026-1 #92

wants to merge 1 commit into from

Conversation

Jules-Bertholet
Copy link
Contributor

Adds support for the alternate normalizations defined by Korean Standard KS X 1026-1 (Korean, English) behind a new ks_x_1026-1 feature flag.

Manishearth
Manishearth requested changes Feb 29, 2024
View reviewed changes
Copy link
Member

@Manishearth Manishearth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple issues:

  • I'm not sure I want to maintain or review this.
  • There are a lot of unrelated changes to the rest of the code. I'm not sure if I'm going to actually review this, but I don't plan to until the PR is performing a single task.

@Jules-Bertholet Jules-Bertholet marked this pull request as draft February 29, 2024 02:56
@Jules-Bertholet Jules-Bertholet mentioned this pull request Feb 29, 2024
Merged
@Jules-Bertholet Jules-Bertholet force-pushed the ks_x_1026-1 branch 7 times, most recently from aa64aa5 to 6b86cc2 Compare February 29, 2024 23:23
@Jules-Bertholet Jules-Bertholet marked this pull request as ready for review February 29, 2024 23:26
@Jules-Bertholet Jules-Bertholet mentioned this pull request Mar 1, 2024
Open
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@Manishearth Manishearth Awaiting requested review from Manishearth

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Jules-Bertholet @Manishearth