Skip to content

Add API to correct defective combining character sequences #98

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

Jules-Bertholet
Copy link
Contributor

No description provided.

Copy link
Member

@Manishearth Manishearth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not convinced this is worth maintaining: it's new data and it's not exactly any algorithm from the standard, which is generally more work to maintain.

For new features I typically would like to see stronger justification why this crate should support them

@Jules-Bertholet
Copy link
Contributor Author

Jules-Bertholet commented Mar 4, 2024

My motivation here is that this API pairs well width unicode-width (or with any terminal that uses similar rules to unicode-width for determining character advance width, IOW ~all of them). Defective combining character sequences are one of the main cases that these width APIs don't handle properly, so correcting them beforehand is useful. (#97 has a similar motivation.)

@Jules-Bertholet Jules-Bertholet force-pushed the correct-defective-ccs branch from b83714b to d4decae Compare March 4, 2024 02:55
@Manishearth
Copy link
Member

In that case please include some description of this API's use cases in its documentation.

I still don't know if or when I'll be able to review this and the other PRs.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants