Add unicode_word_indices #91
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The iterator UnicodeWordIndices is similar to UnicodeWord but also provides byte offsets for each word
|
Retriggering GHA |
Manishearth
approved these changes
Mar 7, 2021
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PR adds a new iterator:
UnicodeWordIndices(and the functionunicode_word_indices). It is similar toUnicodeWordsbut also provides byte offsets for each word.The motivation for this PR was making nushell/reedline#5 in which I used
split_word_bound_indicesand then filtered the result using logic that is internal tounicode_words. I believe that PR would have been trivial usingunicode_word_indices. Hopefully it can also be useful to others.Should I add more tests for
unicode_word_indices? Or are the existing tests forunicode_wordsand the doc test forunicode_word_indicessufficient?