Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

refactor: refine my profile screen #114

Merged
merged 7 commits into from
Apr 25, 2024
Merged

refactor: refine my profile screen #114

merged 7 commits into from
Apr 25, 2024

Conversation

GaelCondeLosada
Copy link
Collaborator

@GaelCondeLosada GaelCondeLosada commented Apr 22, 2024

What I did

Refined and improved slightly the "my profile" screen:

  • Used the styles in profileStyles.ts instead of local styles for the global profile layout.
  • Pass the navigation as a property for the screen.
  • Added a SectionTabs and removed the search bar to prepare the screen to host the events and interests parts.
  • Modified the tests to reflect the changes.

How I did it

With the code editor VScode.

How to verify it

  • Launch the app in expo go and go to "my profile" in the top left.
  • Run the tests.

Demo video

Here is the slightly modified "my profile" screen.

WhatsApp.Video.2024-04-22.at.20.41.27_b85c9670.mp4

Pre-merge checklist

The changes I have introduced:

  • work correctly
  • do not break other functionalities
  • work correctly on Android
  • are fully tested

@GaelCondeLosada GaelCondeLosada marked this pull request as ready for review April 22, 2024 21:07
@Aidasvenc
Copy link
Collaborator

How I did it
With the code editor VScode.

Perfection

Copy link
Collaborator

@Aidasvenc Aidasvenc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect! I am really proud of you improving with React Native so fast. Good job!

Copy link

@GaelCondeLosada GaelCondeLosada merged commit 965420d into main Apr 25, 2024
3 checks passed
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants