-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
feat: google # persistence and auth state #117
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It works on my device ! WhatsApp.Video.2024-04-23.at.12.27.13_b9a93d9d.mp4 |
This was
linked to
issues
Apr 23, 2024
Closed
Fyuryy
approved these changes
Apr 23, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good job Aidas, LGTM
|
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
Re-implemented Google # so that no native modules are required on runtime. The Google # functionality only works in builds, but the whole app is now once again fully testable with Expo Go. Bonus: Google # also works on iOS.
Furthermore, an authentication state persistence was implemented so that users remain signed-in even when the app is closed and re-opened.
Finally, the Login and Logout flow is now fully implemented with the authentication stack (now renamed to
MainStack
) returning either theAuthentication
flow orHomeTabs
based on the user's auth state.All of these functionalities are demonstrated in the demo.
How I did it
expo-auth-session
andexpo-crypto
as well asexpo-web-browser
to handle authentication tokens and redirection to/from a google login web page.auth
methods andAsyncStorage
to keep track of the authentication state and persist it.How to verify it
npx expo start --go
eas
or run it locally withnpx expo prebuild
and thennpm run android
Demo video
WhatsApp.Video.2024-04-23.at.12.27.13_b9a93d9d.mp4
Pre-merge checklist
The changes I have introduced: