-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
feat: linked graph view with navigation #121
Conversation
Don't forget to address sonar cloud issues. |
Yes, don't know why I didn't see those earlier... Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall good work ! I requested a few changes in the code. I also have a few suggestions on the UI.
First I think it could be good to push the modal upwards so we can still use the navigation bar when having a modal on screen:

We'll need the usage of regex, but will probably implement it later:

The graph goes under the present UI. I think this was done on purpose but it personally makes me feel a bit weird (it's maybe just me). Here is the screen I got when opening graph view for the first time:

Aside from that everything is good and everything works on my android device (I validated the works on Android check box) !
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very nice PR.
As more research bars stack-up in the project we will probably need to add some debouncer to avoid having our phones lagging when tapping on the keyboard. Especially in your case this should probably be prioritary for the next sprint!
|
What I did
I linked the graph view with the rest of the app.
I implemented some basic navigation and search functionalities.
I also extracted part of the code from ForceDirectedGraph.tsx and implemented it in another file to have better modularity over components.
How I did it
I added the component inside the ContactGraph.tsx file and added some arguments to ForceDirectedGraph to implement navigation logic.
How to verify it
Demo video
Conversion.video.final.1.mp4
Pre-merge checklist
The changes I have introduced: