fix: resolved fallback problem on App and ScrollView on Event Screen,… #125
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… added back button on EventMap
|
gaspardthrl
reviewed
Apr 26, 2024
gaspardthrl
approved these changes
Apr 26, 2024
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolved bugs that blocked the demo
What I did
I deleted the fallback option on the App screen that blocked the navigation for the HomeScreen
I added a back button on the Event map to go back to the previous screen. I added the styling too and tests for it
I resolved a but on the ScrollView in HomeScreen that prevented to scroll smoothly.
How I did it
I deleted the fallback option as only the redirection to the HomeTabNavigation was necessary.
I added the button "back-arrow"
I deleted the Touchable opacity that was hiding the keyboard, as it conflicted the ScrollView.
Demo video
Pre-merge checklist
The changes I have introduced: