-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Add user data #127
Add user data #127
Conversation
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As I told you by message, I really like the work you did! I was not sure about types vs classes at first but you explained clearly why it made more sense to use types for users. I don't have anything to say except that your code looks good to me!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work ! I didn't have time to check all files in detail but I tested it on android and everything works correctly (I checked the android box). Looks good to me !
Don't forget to address/acknowledge sonar cloud issues before merging. |
What I did
This is a big one. It covers finalizing a complete User registration flow and storing/fetching all User data to/from Firestore Database.
Toast
message is now displayed. This helps the flow to be less blocking (no need to dismiss an alert).Context
and passed during the creation of a user model in the database.types
folder.One detail that we will need to address during our meeting is how to refine the Google Sign-in registration flow. Currently, if a user does a first time sign-in, its' user object in the database cannot be filled in with user information because it has never been filled in. Therefore, in this case we should do one of the two:
Information
and thenInterests
so that he would be forced to fill in initial information.or
UpdateMyProfile
where he would be forced to fill in initial information.both of these ways would require to define some prop for a screen which would indicate whether a user is coming from the google # or not (because the layout would be different, the user in that case should not be able to go back, should not be able to quit and should not be re-directed to
Authentication
afterInterests
). Therefore, we need to define a flow and a mockup in Figma to illustrate how it needs to be implemented.How I did it
Toast
messagesHow to verify it
Try out the registration flow yourself
Demo video
WhatsApp.Video.2024-04-27.at.21.42.38_431ead85.mp4
Pre-merge checklist
The changes I have introduced: