feat: interests from the database #139
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Now interests are fetched from the database rather than written on the code
GaelCondeLosada
requested changes
May 1, 2024
|
Also don't forget to address sonar cloud issues before merging. |
AlbertoCentonze
changed the title
|
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
How I did it
I've written by hand all interests in the database. I decided to create an Interests object, containing a title, a category and an image URL, which will or not be used to import images.
Then I fetch the interests asynchronously. Therefore I had to change the functions logic so it would work with this new implementation.
I tested the interest object and the Interest Screen
How to verify it
Sign-in in the application and go to InterestsScreen, right after InformationScreen. You should see new interests added in the list
Demo video
No need for video as the functionalities of the screen remain strictly the same. The only difference is the listed interests. For now, we have 50 interests of around 6 categories: Music, Sports, Games, General, Fitness, Cooking
Pre-merge checklist
The changes I have introduced: