-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
feat: choose point on map for events #188
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a reminder to delete the log. Otherwise LGTM
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey Gael, thanks for the PR! Can you help me understand why you passed navigation as a prop instead of using the hook as we were doing before?
Also I saw managed to pass functions through navigate
which I couldn't do before, is it for this reason that you passed navigation as a prop?
What I did
EventCreationScreen
How I did it
SelectLocationScreen
and added it to navigation. The screen manages it's own point state internally (meaning the currently selected location is managed internally) but when navigating you can give a call back function for when the date change, the same way as a TextInput.react-native-maps
to implement the map.EventCreationScreen
that redirects to this screen with the right callback function.How to verify it
Launch the application in expo go:
EventCreationScreen
Demo video
WhatsApp.Video.2024-05-13.at.23.47.01_2a3ae089.mp4
Pre-merge checklist
The changes I have introduced: