Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

feat: create friend links between users #193

Merged
merged 8 commits into from
May 17, 2024

Conversation

Fyuryy
Copy link
Collaborator

@Fyuryy Fyuryy commented May 15, 2024

What I did

Created functions to add and remove friends

How I did it

Modified the user file to create the new two functions. Linked the functions to the place where they have to be called in ExternalProfileScreen and tested the globality of the code.

How to verify it

Try to add and/or remove a friend in your profile

Demo video

IMG_4200.MP4

Pre-merge checklist

The changes I have introduced:

  • work correctly
  • do not break other functionalities
  • work correctly on Android
  • are fully tested

@Fyuryy Fyuryy linked an issue May 15, 2024 that may be closed by this pull request
@Fyuryy Fyuryy changed the title Create friend links between users - 181 Create friend links between users May 15, 2024
@AlbertoCentonze AlbertoCentonze changed the title Create friend links between users feat: create friend links between users May 15, 2024
@GustaveCharles GustaveCharles self-requested a review May 15, 2024 20:52
Copy link
Collaborator

@GustaveCharles GustaveCharles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.However, I have not been able to test the functionalities of the PR so I cannot approve it yet.

@Fyuryy Fyuryy closed this May 16, 2024
@Fyuryy Fyuryy force-pushed the 181-create-friend-links-between-users branch from 99d2bbf to 3b31303 Compare May 16, 2024 23:46
@Fyuryy Fyuryy reopened this May 16, 2024
Copy link

@Fyuryy Fyuryy merged commit d81f1cf into main May 17, 2024
3 checks passed
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

create friend links between users
2 participants